Fix: Prevent Adapt.on('popup:opened') listener leak in openPopup (fixes #345) - #346
Open
oliverfoster wants to merge 1 commit into
Open
Fix: Prevent Adapt.on('popup:opened') listener leak in openPopup (fixes #345)#346oliverfoster wants to merge 1 commit into
oliverfoster wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #345
Fix
popup:openedhandler once viathis.listenTo(Adapt, ...)inpreRender(), instead of callingAdapt.on()insideopenPopup()on every invocation — Backbone unbinds it automatically when the view is removedNotifyPopupViewreturned bynotify.popup(), instead of reacting to any popup opened anywhere in the courseTesting
Adapt._events['popup:opened'].lengthno longer growsnotify.popup()/alert) and confirm the narrative item's visited state is unaffected